xunliu commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849480387
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -551,4 +551,8 @@ public String getUrl() {
// Return the default localhost URL
return DEFAULT_URL;
}
+
+ public static Options getOptions() {
+ return options;
+ }
Review Comment:
I think it better to pass `Options` in the function params, because
1. The `Options` is a common class.
2. Different command need different params, we can be unified pass `Options`
params, Otherwise the function will have too many arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
