justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1849554303
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -551,4 +551,8 @@ public String getUrl() {
// Return the default localhost URL
return DEFAULT_URL;
}
+
+ public static Options getOptions() {
+ return options;
+ }
Review Comment:
The org.apache.commons.cli.Options class is specific to a particular
library, so avoiding including it directly in the command signature is best
from a maintainability point of view. Additionally, passing Options makes it
harder to identify which specific options a command requires. It’s better for
code understanding to be explicit about each command's required options. Also,
these changes should follow the style of other commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
