justinmclean commented on code in PR #5618:
URL: https://github.com/apache/gravitino/pull/5618#discussion_r1853313712
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/AddRoleToUser.java:
##########
@@ -38,13 +38,21 @@ public class AddRoleToUser extends Command {
*
* @param url The URL of the Gravitino server.
* @param ignoreVersions If true don't check the client/server versions
match.
+ * @param authentication Authentication type i.e. "simple"
+ * @param userName User name for simple authentication.
* @param metalake The name of the metalake.
* @param user The name of the user.
* @param role The name of the role.
*/
public AddRoleToUser(
- String url, boolean ignoreVersions, String metalake, String user, String
role) {
- super(url, ignoreVersions);
+ String url,
+ boolean ignoreVersions,
+ String authentication,
Review Comment:
This change was made in another PR, but thanks for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]