justinmclean commented on code in PR #5618:
URL: https://github.com/apache/gravitino/pull/5618#discussion_r1870733856
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/Command.java:
##########
@@ -115,12 +136,26 @@ protected GravitinoAdminClient buildAdminClient() {
client = client.withVersionCheckDisabled();
}
if (authentication != null) {
- if (authentication.equals("simple")) {
+ if (authentication.equals(SIMPLE_AUTH)) {
if (userName != null && !userName.isEmpty()) {
client = client.withSimpleAuth(userName);
} else {
client = client.withSimpleAuth();
}
+ } else if (authentication.equals(OAUTH_AUTH)) {
Review Comment:
There was no way I coudl find to reuse it I did try. One part of the code
uses GravitinoAdminClient and the other GravitinoClient, which are not
interchangeable when using the Builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
