tengqm commented on code in PR #5629:
URL: https://github.com/apache/gravitino/pull/5629#discussion_r1853759002
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java:
##########
@@ -86,6 +86,9 @@ public RangerHelper(
*/
void checkPolicyItemAccess(RangerPolicy.RangerPolicyItem policyItem)
throws AuthorizationPluginException {
+ if (!isGravitinoManagedPolicyItemAccess(policyItem)) {
+ return;
Review Comment:
Emm...
Not sure I understand the invocation protocol here.
From the function comment, I can guess that the function (a check) succeeds
when it returns, and we use an exception to signify a failure.
If that is the case, should we raise an exception on line 90, rather than
pretending it was a success?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
