xunliu commented on code in PR #5629:
URL: https://github.com/apache/gravitino/pull/5629#discussion_r1858230717
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java:
##########
@@ -61,6 +59,11 @@ public class RangerHelper {
public static final String GRAVITINO_METALAKE_OWNER_ROLE =
"GRAVITINO_METALAKE_OWNER_ROLE";
public static final String GRAVITINO_CATALOG_OWNER_ROLE =
"GRAVITINO_CATALOG_OWNER_ROLE";
+ // marking owner policy items
+ public static final String GRAVITINO_PLACEHOLDER_OWNER_ROLE =
"GRAVITINO_PLACEHOLDER_OWNER_ROLE";
+
+ public static final String GRAVITINO_ROLE_PREFIX = "GRAVITINO_";
+
Review Comment:
I think it's better to change these code
```
public static final String GRAVITINO_ROLE_PREFIX = "GRAVITINO_";
public static final String GRAVITINO_METALAKE_OWNER_ROLE =
GRAVITINO_ROLE_PREFIX + "METALAKE_OWNER_ROLE";
public static final String GRAVITINO_CATALOG_OWNER_ROLE =
GRAVITINO_ROLE_PREFIX + "CATALOG_OWNER_ROLE";
// marking owner policy items
public static final String GRAVITINO_OWNER_ROLE = GRAVITINO_ROLE_PREFIX +
"OWNER_ROLE";
```
The `GRAVITINO_PLACEHOLDER_OWNER_ROLE ` is too long.
I think we need to add a description(`GRAVITINO_ROLE_PREFIX`,
`GRAVITINO_METALAKE_OWNER_ROLE`, `GRAVITINO_CATALOG_OWNER_ROLE` and
`GRAVITINO_OWNER_ROLE`) in the
https://github.com/apache/gravitino/blob/main/docs/security/authorization-pushdown.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
