SophieTech88 commented on code in PR #5646:
URL: https://github.com/apache/gravitino/pull/5646#discussion_r1868770901
##########
clients/client-python/gravitino/api/types/types.py:
##########
@@ -123,7 +123,7 @@ def get(cls) -> "ShortType":
return cls(True)
@classmethod
- def unsigned(cls):
+ def unsigned(cls) -> "ShortType":
Review Comment:
```
class ShortType(IntegralType):
_instance: "ShortType" = None
_unsigned_instance: "ShortType" = None
```
The type annotation ShortType is quoted because `_instance` is an attribute
of the class that references ShortType, and the class itself isn't fully
defined at the time this attribute is declared.
The return type annotations (-> "ShortType") are also quoted for the same
reason: `ShortType` isn't fully defined when these methods are declared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
