tengqm commented on code in PR #5646:
URL: https://github.com/apache/gravitino/pull/5646#discussion_r1868974650
##########
clients/client-python/gravitino/api/types/types.py:
##########
@@ -123,7 +123,7 @@ def get(cls) -> "ShortType":
return cls(True)
@classmethod
- def unsigned(cls):
+ def unsigned(cls) -> "ShortType":
Review Comment:
Em... I am not a big fan of passing lint checking simply for passing's
purpose.
At the end of the day, we are the maintainers to maintain these code.
If lint rules are not appropriate in our context, we may want to disable that
particular rule. It is not an uncommon practice.
At the same time, if we are forced to "hack" the code to make the linter
happy,
we may need to revise our design. Probably there are more straightforward
ways
to achieve the same end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
