justinmclean commented on code in PR #5618:
URL: https://github.com/apache/gravitino/pull/5618#discussion_r1870752897
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/Command.java:
##########
@@ -115,12 +136,26 @@ protected GravitinoAdminClient buildAdminClient() {
client = client.withVersionCheckDisabled();
}
if (authentication != null) {
- if (authentication.equals("simple")) {
+ if (authentication.equals(SIMPLE_AUTH)) {
if (userName != null && !userName.isEmpty()) {
client = client.withSimpleAuth(userName);
} else {
client = client.withSimpleAuth();
}
+ } else if (authentication.equals(OAUTH_AUTH)) {
Review Comment:
If you extract the common code and try using it from both methods, you get
errors with converting to/from `Builder<GravitinoClient>` and
`Builder<GravitinoAdminClient>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
