justinmclean commented on code in PR #5811:
URL: https://github.com/apache/gravitino/pull/5811#discussion_r1877411373
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -385,27 +385,19 @@ protected void handleUserCommand() {
boolean force = line.hasOption(GravitinoOptions.FORCE);
newDeleteUser(url, ignore, force, metalake, user).handle();
} else if (CommandActions.REVOKE.equals(command)) {
+ // Retrieve values of the role option from the command line, e.g.,
["role1", "role2"]
Review Comment:
There is no need for comments like this that say what the code is doing. In
general comments should explain why design choices were made or explain complex
code. Sometimes comments like this get out of sync with the code and ending up
confusing people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
