Abyss-lord commented on code in PR #5811:
URL: https://github.com/apache/gravitino/pull/5811#discussion_r1877702909
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java:
##########
@@ -100,12 +100,12 @@ public Options options() {
options.addOption(createArgOption(AUTO, "column value auto-increments
(true/false)"));
options.addOption(createArgOption(DEFAULT, "default column value"));
options.addOption(createSimpleOption("o", OWNER, "display entity owner"));
- options.addOption(createArgOption("r", ROLE, "role name"));
options.addOption(createArgOption(COLUMNFILE, "CSV file describing
columns"));
// Properties and tags can have multiple values
Review Comment:
Thank you Justin, I update the comment to `Options that support multiple
values` and remove redundant comments
> As I said above, saying something like "Options that support multiple
values" might be better. Once you have more than two things, making it more
generic is better. If you were to change it your way, something like this would
be better: "properties, tags and roles...". either would be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
