tengqm commented on code in PR #5907:
URL: https://github.com/apache/gravitino/pull/5907#discussion_r1894726661
##########
clients/cli/src/main/java/org/apache/gravitino/cli/CommandActions.java:
##########
@@ -52,6 +54,8 @@ public class CommandActions {
VALID_COMMANDS.add(PROPERTIES);
VALID_COMMANDS.add(REVOKE);
VALID_COMMANDS.add(GRANT);
+ VALID_COMMANDS.add(ENABLE);
+ VALID_COMMANDS.add(DISABLE);
Review Comment:
I don't think we should add "enable/disable" as top-level commands
considering that these actions are only applicable to metalakes and catalogs.
I'd model these as toggling a flag on metalakes and catalogs. i.e.
```shell
gcli metalake update --enable
```
This is a weak opinion.
In that spirit, I'd name the classes/methods as `MetalakeEnable` rather than
`EnableMetalake`, for example. This, however, is a strong opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
