Re: [PR] [#5826] fix(CLI): Fix Dropping a metalake via the Gravitino CLI gives an "in use" exception [gravitino]

Sat, 21 Dec 2024 18:03:32 -0800 


Abyss-lord commented on code in PR #5907:
URL: https://github.com/apache/gravitino/pull/5907#discussion_r1894728239


##########
clients/cli/src/main/java/org/apache/gravitino/cli/CommandActions.java:
##########
@@ -52,6 +54,8 @@ public class CommandActions {
     VALID_COMMANDS.add(PROPERTIES);
     VALID_COMMANDS.add(REVOKE);
     VALID_COMMANDS.add(GRANT);
+    VALID_COMMANDS.add(ENABLE);
+    VALID_COMMANDS.add(DISABLE);

Review Comment:
   
![image](https://github.com/user-attachments/assets/57d84627-3450-4e1f-94f2-5e389e36bc2a)
   
   If we not added these commands to VALID_COMMANDS, we would have needed to 
modify the command validation flow.
   I will change the name, thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to