tengqm commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897848602
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -762,6 +775,12 @@ protected void handleRoleCommand() {
}
}
+ private String getOneRole(String[] roles, String command) {
+ Preconditions.checkArgument(
+ roles.length == 1, command + " requires only one role, but multiple
are currently passed.");
Review Comment:
I think what Justin suggested was that to check if this actually happens.
If the `--role` option is supposed to be specified only once, would it be
possible for a users to specify that option for multiple times?
If the answer is no, we don't need this check.
It the answer is yes, we have a serious problem regarding command line
option checking. I mean, we have too many cases to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
