Abyss-lord commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1898373351
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -762,6 +775,12 @@ protected void handleRoleCommand() {
}
}
+ private String getOneRole(String[] roles, String command) {
+ Preconditions.checkArgument(
+ roles.length == 1, command + " requires only one role, but multiple
are currently passed.");
Review Comment:
@tengqm `gcli role details -m demo_metalake --role roleA roleB`, The check
is meant to prevent such example. IHMO, We should keep this check.
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -762,6 +775,12 @@ protected void handleRoleCommand() {
}
}
+ private String getOneRole(String[] roles, String command) {
+ Preconditions.checkArgument(
+ roles.length == 1, command + " requires only one role, but multiple
are currently passed.");
Review Comment:
@tengqm `gcli role details -m demo_metalake --role roleA roleB`, The check
is meant to prevent such example. IHMO, We should keep this check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
