FANNG1 commented on code in PR #5992:
URL: https://github.com/apache/gravitino/pull/5992#discussion_r1900397056
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/storage/GCSProperties.java:
##########
@@ -22,7 +22,7 @@
public class GCSProperties {
// The path of service account JSON file of Google Cloud Storage.
- public static final String GCS_SERVICE_ACCOUNT_JSON_PATH =
"gcs-service-account-file";
+ public static final String GRAVITINO_GCS_SERVICE_ACCOUNT_FILE =
"gcs-service-account-file";
Review Comment:
Gravitino as a metadata manage system, there are heavy works to transform
different properties across different systems, take jdbc user for example, the
name is `jdbc-user` for Gravitino, `jdbc.user` for Iceberg, adding a prefix
like `GRAVITINO_JDBC_USER`, `ICEBERG_JDBC_USER` is more clear to me, without
the prefix we may use it by mistake more easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
