FANNG1 commented on code in PR #5992:
URL: https://github.com/apache/gravitino/pull/5992#discussion_r1900397557
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/storage/GCSProperties.java:
##########
@@ -22,7 +22,7 @@
public class GCSProperties {
// The path of service account JSON file of Google Cloud Storage.
- public static final String GCS_SERVICE_ACCOUNT_JSON_PATH =
"gcs-service-account-file";
+ public static final String GRAVITINO_GCS_SERVICE_ACCOUNT_FILE =
"gcs-service-account-file";
Review Comment:
another pattern is splitting to something like
`GravitinoProperties.JDBC_USER` `IcebergProperties.JDBC_USER`, I agree this is
more elegant and clear too, but requires an heavy refactor work for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
