justinmclean commented on code in PR #6066:
URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901482170


##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -1183,6 +1185,38 @@ private void handleModelCommand() {
         newModelDetails(url, ignore, metalake, catalog, schema, 
model).handle();
         break;
 
+      case CommandActions.CREATE:
+        String createComment = line.getOptionValue(GravitinoOptions.COMMENT);
+        String[] createProperties = 
line.getOptionValues(GravitinoOptions.PROPERTIES);
+        Map<String, String> createPropertyMap = new 
Properties().parse(createProperties);
+        newCreateModel(
+                url, ignore, metalake, catalog, schema, model, createComment, 
createPropertyMap)
+            .handle();
+        break;
+
+      case CommandActions.UPDATE:
+        if (uri == null) {

Review Comment:
   I don't think the model REST interface is 100% complete. The CLI uses the 
Java interface, which has no formal spec.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to