justinmclean commented on code in PR #6066:
URL: https://github.com/apache/gravitino/pull/6066#discussion_r1901518914
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -1175,6 +1175,8 @@ private void handleModelCommand() {
}
String model = name.getModelName();
+ String[] alias = line.getOptionValues(GravitinoOptions.ALIAS);
+ String uri = line.getOptionValue(GravitinoOptions.URI);
Review Comment:
They are needed for your commands but not all commands, just define the
variables where they are required. I know there is no case scope in Java
(unless you add some {}s) , but defining them nearer to where they are used
makes the code more understandable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
