jerqi commented on code in PR #6100:
URL: https://github.com/apache/gravitino/pull/6100#discussion_r1903600655
##########
authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java:
##########
@@ -183,36 +540,66 @@ public List<AuthorizationSecurableObject>
translatePrivilege(SecurableObject sec
// in the RangerAuthorizationHDFSPlugin.
break;
case USE_SCHEMA:
+ switch (securableObject.type()) {
+ case METALAKE:
+ case CATALOG:
+ case SCHEMA:
+ AuthorizationUtils.getMetadataObjectLocation(
+ identifier,
MetadataObjectUtil.toEntityType(securableObject))
+ .stream()
+ .forEach(
+ locationPath -> {
+ PathBasedMetadataObject pathBaseMetadataObject
=
+ new PathBasedMetadataObject(
+ securableObject.parent(),
+ securableObject.name(),
+ locationPath,
+ PathBasedMetadataObject.Type.PATH);
+
pathBaseMetadataObject.validateAuthorizationMetadataObject();
+ rangerSecurableObjects.add(
+ generateAuthorizationSecurableObject(
+ pathBaseMetadataObject.names(),
+ locationPath,
+ PathBasedMetadataObject.Type.PATH,
+ rangerPrivileges));
+ });
+ break;
+ default:
+ checkOmissionTranslate(
Review Comment:
`Omission`? This is not a clear name.
##########
api/src/main/java/org/apache/gravitino/authorization/MetadataObjectChange.java:
##########
@@ -44,10 +45,11 @@ static MetadataObjectChange rename(
* Remove a metadata entity MetadataObjectChange.
*
* @param metadataObject The metadata object.
+ * @param locations The locations of the metadata object.
* @return return a MetadataObjectChange for the remove metadata object.
*/
- static MetadataObjectChange remove(MetadataObject metadataObject) {
- return new RemoveMetadataObject(metadataObject);
+ static MetadataObjectChange remove(MetadataObject metadataObject,
List<String> locations) {
Review Comment:
Does the `rename` need this similar parameter?
##########
.github/workflows/backend-integration-test-action.yml:
##########
@@ -60,7 +60,8 @@ jobs:
-x :web:web:test -x :web:integration-test:test -x
:clients:client-python:test -x :flink-connector:flink:test -x
:spark-connector:spark-common:test
-x :spark-connector:spark-3.3:test -x
:spark-connector:spark-3.4:test -x :spark-connector:spark-3.5:test
-x :spark-connector:spark-runtime-3.3:test -x
:spark-connector:spark-runtime-3.4:test -x
:spark-connector:spark-runtime-3.5:test
- -x :authorizations:authorization-ranger:test -x
:trino-connector:integration-test:test -x :trino-connector:trino-connector:test
+ -x :trino-connector:integration-test:test -x
:trino-connector:trino-connector:test
Review Comment:
We have access control pipeline.Why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
