FANNG1 commented on code in PR #5974:
URL: https://github.com/apache/gravitino/pull/5974#discussion_r1908623989
##########
bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/OSSFileSystemProvider.java:
##########
@@ -61,9 +66,22 @@ public FileSystem getFileSystem(Path path, Map<String,
String> config) throws IO
}
hadoopConfMap.forEach(configuration::set);
+
return AliyunOSSFileSystem.newInstance(path.toUri(), configuration);
}
+ @Override
+ public Map<String, String> getFileSystemCredentialConf(Credential[]
credentials) {
+ Credential credential =
OSSCredentialsProvider.getSuitableCredential(credentials);
Review Comment:
Could you move `getSuitableCredential` to an util class? It's odd to invoke
`OSSCredentialsProvider` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
