FANNG1 commented on code in PR #5974:
URL: https://github.com/apache/gravitino/pull/5974#discussion_r1908617672


##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##########
@@ -410,6 +330,37 @@ private FilesetContextPair getFilesetContext(Path 
virtualPath, FilesetDataOperat
     return new FilesetContextPair(new Path(actualFileLocation), fs);
   }
 
+  private Map<String, String> getCredentialProperties(
+      FileSystemProvider fileSystemProvider,
+      Catalog catalog,
+      NameIdentifier filesetIdentifier,
+      String virtualPathString) {
+    Map<String, String> maps = Maps.newHashMap();
+    try {
+      Fileset fileset =
+          catalog
+              .asFilesetCatalog()
+              .loadFileset(
+                  NameIdentifier.of(
+                      filesetIdentifier.namespace().level(2), 
filesetIdentifier.name()));
+      Credential[] credentials = 
fileset.supportsCredentials().getCredentials();
+      if (credentials.length > 0 && fileSystemProvider instanceof 
SupportsCredentialVending) {

Review Comment:
   could you get credentials when `fileSystemProvider` is 
`SupportsCredentialVending`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to