jerryshao commented on code in PR #6318:
URL: https://github.com/apache/gravitino/pull/6318#discussion_r1919818159
##########
.github/workflows/docker-image.yml:
##########
@@ -115,8 +126,10 @@ jobs:
sudo rm -rf /usr/local/lib/android
sudo rm -rf /opt/hostedtoolcache/CodeQL
- if [[ "${image_type}" == "gravitino" || "${image_type}" ==
"iceberg-rest-server" ]]; then
+ if [[ "${publish_latest}" == "true" ]]; then
+ echo "Publish latest tag"
./dev/docker/build-docker.sh --platform all --type ${image_type}
--image ${image_name} --tag ${{ github.event.inputs.version }} --latest
else
+ echo "Doesn't publish latest tag"
./dev/docker/build-docker.sh --platform all --type ${image_type}
--image ${image_name} --tag "${tag_name}-${{ github.event.inputs.version }}"
Review Comment:
This `if...else...` is not correct, we should always build the image with
tag names, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
