jerryshao commented on code in PR #6318:
URL: https://github.com/apache/gravitino/pull/6318#discussion_r1919981046
##########
.github/workflows/docker-image.yml:
##########
@@ -115,8 +126,16 @@ jobs:
sudo rm -rf /usr/local/lib/android
sudo rm -rf /opt/hostedtoolcache/CodeQL
- if [[ "${image_type}" == "gravitino" || "${image_type}" ==
"iceberg-rest-server" ]]; then
- ./dev/docker/build-docker.sh --platform all --type ${image_type}
--image ${image_name} --tag ${{ github.event.inputs.version }} --latest
+ if [[ -n "${tag_name}" ]];then
+ full_tag_name="${tag_name}-${{ github.event.inputs.version }}"
+ else
+ full_tag_name="${{ github.event.inputs.version }}"
+ fi
+
+ if [[ "${publish_latest}" == "true" ]]; then
+ echo "Publish tag ${full_tag_name}, and update latest too."
+ ./dev/docker/build-docker.sh --platform all --type ${image_type}
--image ${image_name} --tag ${full_tag_name} --latest
else
- ./dev/docker/build-docker.sh --platform all --type ${image_type}
--image ${image_name} --tag "${tag_name}-${{ github.event.inputs.version }}"
- fi
\ No newline at end of file
+ echo "Publish tag ${full_tag_name}, doesn't update latest."
Review Comment:
Remove this ", doesn't update latest", it is not useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
