FANNG1 commented on code in PR #6280:
URL: https://github.com/apache/gravitino/pull/6280#discussion_r1942189545
##########
clients/filesystem-fuse/src/open_dal_filesystem.rs:
##########
@@ -120,14 +122,27 @@ impl PathFileSystem for OpenDalFileSystem {
.map_err(opendal_error_to_errno)?;
file.reader = Some(Box::new(FileReaderImpl { reader }));
}
- if flags.is_write() || flags.is_create() || flags.is_append() ||
flags.is_truncate() {
+ if !flags.is_create() && flags.is_append() {
+ error!("The file system does not support open a exists file with
the append mode");
+ return Err(Errno::from(libc::EBADF));
Review Comment:
is it proper to return `EBADF`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
