diqiu50 commented on code in PR #6280:
URL: https://github.com/apache/gravitino/pull/6280#discussion_r1942290980
##########
clients/filesystem-fuse/src/open_dal_filesystem.rs:
##########
@@ -120,14 +122,27 @@ impl PathFileSystem for OpenDalFileSystem {
.map_err(opendal_error_to_errno)?;
file.reader = Some(Box::new(FileReaderImpl { reader }));
}
- if flags.is_write() || flags.is_create() || flags.is_append() ||
flags.is_truncate() {
+ if !flags.is_create() && flags.is_append() {
+ error!("The file system does not support open a exists file with
the append mode");
Review Comment:
There should be an error here. The operation cannot continue.
##########
clients/filesystem-fuse/Makefile:
##########
@@ -62,6 +62,9 @@ doc-test:
unit-test: doc-test
cargo test --no-fail-fast --lib --all-features --workspace
+test-it:
Review Comment:
`test-it` removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
