jerryshao commented on code in PR #7037:
URL: https://github.com/apache/gravitino/pull/7037#discussion_r2061953270
##########
api/src/main/java/org/apache/gravitino/model/ModelVersionChange.java:
##########
@@ -71,6 +79,26 @@ static ModelVersionChange updateUri(String newUri) {
return new ModelVersionChange.UpdateUri(newUri);
}
+ /**
+ * Create a ModelVersionChange for updating the aliases of a model version.
+ *
+ * @param newAlias The new aliases to be set for the model version.
+ * @return A new ModelVersionChange instance for updating the alias of a
model version.
+ */
+ static ModelVersionChange updateAlias(String... newAlias) {
Review Comment:
I would suggest changing the interface to something like:
```
static ModelVersionChange updateAliases(String[] aliasesToAdd, String[]
aliasesToRemove)
```
So this one API can support both adding and deleting aliases. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
