jerryshao commented on code in PR #7037:
URL: https://github.com/apache/gravitino/pull/7037#discussion_r2065335587
##########
catalogs/catalog-model/src/main/java/org/apache/gravitino/catalog/model/ModelCatalogOperations.java:
##########
@@ -435,6 +435,12 @@ private ModelVersionEntity updateModelVersionEntity(
ModelVersionChange.UpdateUri updateUriChange =
(ModelVersionChange.UpdateUri) change;
entityUri = updateUriChange.newUri();
+ } else if (change instanceof ModelVersionChange.UpdateAliases) {
+ ModelVersionChange.UpdateAliases updateAliasesChange =
+ (ModelVersionChange.UpdateAliases) change;
+ doDeleteAlias(entityAliases, updateAliasesChange);
+ doSetAlias(entityAliases, updateAliasesChange);
Review Comment:
Again, how do you handle the scenario where `aliasesToAdd` and
`aliasesToDelete` are the same. For example, `aliasesToAdd` and
`aliasesToDelete` are `{"alias1"}`, the "alias1" will be added finally, is it
an expected behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
