xunliu commented on code in PR #7112:
URL: https://github.com/apache/gravitino/pull/7112#discussion_r2074602604
##########
dev/docker/ranger/ranger-dependency.sh:
##########
@@ -41,30 +41,32 @@ if [ ! -f "${ranger_dir}/packages/${RANGER_PACKAGE_NAME}"
]; then
git clone https://github.com/apache/ranger --branch master --single-branch
${ranger_dir}/packages/apache-ranger
# set the commit to RANGER-5146: 500 API Error When Deleting TagDef with a
Linked Tag
#
https://github.com/apache/ranger/commit/ff36aabe36169b94862c51a5b403f59c9d728b94
+ cd ${ranger_dir}/packages/apache-ranger
git reset --hard ff36aabe36169b94862c51a5b403f59c9d728b94
Review Comment:
I think we need special `2.4.0` tag?
##########
dev/docker/ranger/docker-compose.ranger-build.yml:
##########
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+version: "3"
+services:
+ ranger-build:
+ build:
+ context: .
+ dockerfile: Dockerfile.ranger-build
+ args:
+ - RANGER_BUILD_JAVA_VERSION=${RANGER_BUILD_JAVA_VERSION}
+ image: ranger-build
+ container_name: ranger-build
+ hostname: ranger-build.example.com
+ privileged: true
+ networks:
+ - ranger
+ volumes:
+ # SELinux
+ # https://github.com/moby/moby/issues/41202#issuecomment-657422171
+ - m2:/home/ranger/.m2:Z
+ - ./scripts:/home/ranger/scripts
+ - ./patches:/home/ranger/patches
+ - dist:/home/ranger/dist:Z
+ - ${RANGER_HOME:-./../../}:/home/ranger/src:Z
Review Comment:
The `./../../` is very confusing. Can we use other variable??
##########
.github/workflows/docker-image.yml:
##########
@@ -19,11 +19,15 @@ on:
- 'gravitino-playground:hive'
- 'gravitino-playground:ranger'
- 'gravitino-iceberg-rest-server'
+ docker_repo_name:
+ description: 'Docker repository name (default is apache)'
+ required: false
+ default: 'apache'
+ type: string
Review Comment:
I think we didn't need this, Please remove it, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
