Re: [PR] [#7101] Improvement(docker-image): fix ranger docker image build failure in CI [gravitino]

Wed, 07 May 2025 17:37:53 -0700 


unknowntpo commented on code in PR #7112:
URL: https://github.com/apache/gravitino/pull/7112#discussion_r2078713377


##########
.github/workflows/docker-image.yml:
##########
@@ -19,11 +19,15 @@ on:
           - 'gravitino-playground:hive'
           - 'gravitino-playground:ranger'
           - 'gravitino-iceberg-rest-server'
+      docker_repo_name:
+        description: 'Docker repository name (default is apache)'
+        required: false
+        default: 'apache'
+        type: string

Review Comment:
   @xunliu  I think this is needed, without this, developers can not test the 
`Publish Docker image` workflow at their own Github repo and Docker repo, since 
it always push newly built image to `apache` Docker repo.
   
   ![Screenshot 2025-05-08 at 8 34 08 
AM](https://github.com/user-attachments/assets/b5a81175-4c39-465f-9b6c-69d305b9e895)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to