Abyss-lord commented on code in PR #7133:
URL: https://github.com/apache/gravitino/pull/7133#discussion_r2081091420
##########
api/src/main/java/org/apache/gravitino/model/ModelVersionChange.java:
##########
@@ -361,20 +361,20 @@ public String toString() {
*/
final class UpdateAliases implements ModelVersionChange {
private final ImmutableSortedSet<String> aliasesToAdd;
- private final ImmutableSortedSet<String> aliasesToDelete;
+ private final ImmutableSortedSet<String> aliasesToRemove;
/**
* Constructs a new aliases-update operation, specifying the aliases to
add and remove.
*
* @param aliasesToAdd the aliases to add, or null for none
- * @param aliasesToDelete the aliases to remove, or null for none
+ * @param aliasesToRemove the aliases to remove, or null for none
Review Comment:
@jerryshao Just Be consistent with Tag, e.g. (tagToRemove tagToAdd)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
