jerryshao commented on code in PR #7133:
URL: https://github.com/apache/gravitino/pull/7133#discussion_r2081100164


##########
clients/client-python/gravitino/api/model_version_change.py:
##########
@@ -240,3 +251,58 @@ class name followed by the new URI of the model version.
                 A string summary of this URI update operation.
             """
             return f"UpdateUri {self._new_uri}"
+
+    class UpdateAliases:
+        """A model version change to update the aliases of the model 
version."""
+
+        def __init__(self, aliases_to_add, aliases_to_delete):
+            self.aliases_to_add = set(aliases_to_add)
+            self.aliases_to_remove = set(aliases_to_delete)
+
+        def add_aliases(self):
+            """Retrieves the aliases to add.
+            Returns:
+                The aliases to add.
+            """
+            return self.aliases_to_add
+
+        def remove_aliases(self):

Review Comment:
   The method name should align with Java one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to