justinmclean commented on code in PR #7317:
URL: https://github.com/apache/gravitino/pull/7317#discussion_r2136889285
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -209,18 +282,39 @@ public String toCatalogConfig() {
return StringUtils.join(stringList, ',');
}
+ /**
+ * Retrieves the metadata refresh interval in seconds.
+ *
+ * @return the metadata refresh interval in seconds
+ */
public String getMetadataRefreshIntervalSecond() {
return config.getOrDefault(
GRAVITINO_METADATA_REFRESH_INTERVAL_SECOND.key,
GRAVITINO_METADATA_REFRESH_INTERVAL_SECOND.defaultValue);
}
+ /** Configuration entry class that holds the definition of a configuration
parameter. */
static class ConfigEntry {
+ /** The configuration key */
final String key;
+
+ /** The description of the configuration parameter */
final String description;
+
+ /** The default value of the configuration parameter */
final String defaultValue;
+
+ /** Whether this configuration parameter is required */
final boolean isRequired;
Review Comment:
Again, I'm not sure these comments add any value. Also, why "configuration
parameter" when the class is not called that? The distinction between a
parameter and an entry may be subtle, but it is nonetheless distinct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
