justinmclean commented on code in PR #7317:
URL: https://github.com/apache/gravitino/pull/7317#discussion_r2136892302
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoErrorCode.java:
##########
@@ -25,32 +25,59 @@
import io.trino.spi.ErrorType;
import java.util.List;
+/** Gravitino error code. */
public enum GravitinoErrorCode implements ErrorCodeSupplier {
+ /** Unsupported Trino version. */
GRAVITINO_UNSUPPORTED_TRINO_VERSION(0, EXTERNAL),
+ /** Metalake not exists. */
GRAVITINO_METALAKE_NOT_EXISTS(1, EXTERNAL),
+ /** Missing config. */
GRAVITINO_MISSING_CONFIG(2, EXTERNAL),
+ /** Create inner connector failed. */
GRAVITINO_CREATE_INNER_CONNECTOR_FAILED(3, EXTERNAL),
+ /** Unsupported catalog provider. */
GRAVITINO_UNSUPPORTED_CATALOG_PROVIDER(4, EXTERNAL),
+ /** Create internal connector error. */
GRAVITINO_CREATE_INTERNAL_CONNECTOR_ERROR(5, EXTERNAL),
+ /** Schema not exists. */
GRAVITINO_SCHEMA_NOT_EXISTS(6, EXTERNAL),
+ /** Catalog not exists. */
GRAVITINO_CATALOG_NOT_EXISTS(7, EXTERNAL),
+ /** Table not exists. */
GRAVITINO_TABLE_NOT_EXISTS(8, EXTERNAL),
+ /** Unsupported Trino datatype. */
GRAVITINO_UNSUPPORTED_TRINO_DATATYPE(9, EXTERNAL),
+ /** Unsupported Gravitino datatype. */
GRAVITINO_UNSUPPORTED_GRAVITINO_DATATYPE(10, EXTERNAL),
+ /** Unsupported operation. */
GRAVITINO_UNSUPPORTED_OPERATION(11, EXTERNAL),
+ /** Column not exists. */
GRAVITINO_COLUMN_NOT_EXISTS(12, EXTERNAL),
+ /** Schema already exists. */
GRAVITINO_SCHEMA_ALREADY_EXISTS(13, EXTERNAL),
+ /** Table already exists. */
GRAVITINO_TABLE_ALREADY_EXISTS(14, EXTERNAL),
+ /** Schema not empty. */
GRAVITINO_SCHEMA_NOT_EMPTY(15, EXTERNAL),
+ /** Illegal argument. */
GRAVITINO_ILLEGAL_ARGUMENT(16, EXTERNAL),
+ /** Inner connector exception. */
GRAVITINO_INNER_CONNECTOR_EXCEPTION(17, EXTERNAL),
+ /** Iceberg unsupported JDBC type. */
GRAVITINO_ICEBERG_UNSUPPORTED_JDBC_TYPE(18, EXTERNAL),
+ /** Missing required property. */
GRAVITINO_MISSING_REQUIRED_PROPERTY(19, EXTERNAL),
+ /** Catalog already exists. */
GRAVITINO_CATALOG_ALREADY_EXISTS(20, EXTERNAL),
+ /** Metalake already exists. */
GRAVITINO_METALAKE_ALREADY_EXISTS(21, EXTERNAL),
+ /** Operation failed. */
GRAVITINO_OPERATION_FAILED(22, EXTERNAL),
+ /** Runtime error. */
GRAVITINO_RUNTIME_ERROR(23, EXTERNAL),
+ /** Duplicated catalogs. */
GRAVITINO_DUPLICATED_CATALOGS(24, EXTERNAL),
+ /** Expression error. */
GRAVITINO_EXPRESSION_ERROR(25, EXTERNAL);
Review Comment:
These comments add little value and make the code harder to read and
maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
