Abyss-lord commented on code in PR #7354:
URL: https://github.com/apache/gravitino/pull/7354#discussion_r2142011286
##########
core/src/main/java/org/apache/gravitino/storage/relational/RelationalEntityStore.java:
##########
@@ -83,47 +106,91 @@ private static RelationalBackend
createRelationalEntityBackend(Config config) {
@Override
public <E extends Entity & HasIdentifier> List<E> list(
Namespace namespace, Class<E> type, Entity.EntityType entityType) throws
IOException {
- return backend.list(namespace, entityType, false);
+ return cache.withCacheLock(
Review Comment:
@jerryshao We've updated the locking strategy:
- In `RelationalEntityStore`, all operations except `get` and
`listEntitiesByRelation` are no longer wrapped in withCacheLock.
- In `CaffeineEntityCache`, only mutating operations (`put`, `invalidate`,
`clear`, etc.) are protected by locks. Methods like `contains` and
`getIfPresent` are left lock-free, since Caffeine is thread-safe for read
access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
