Abyss-lord commented on code in PR #7354:
URL: https://github.com/apache/gravitino/pull/7354#discussion_r2141635576
##########
core/src/main/java/org/apache/gravitino/storage/relational/RelationalEntityStore.java:
##########
@@ -54,12 +61,28 @@ public class RelationalEntityStore
Configs.DEFAULT_ENTITY_RELATIONAL_STORE,
JDBCBackend.class.getCanonicalName());
private RelationalBackend backend;
private RelationalGarbageCollector garbageCollector;
+ private EntityCache cache;
+ private Set<Namespace> namespaceSet;
+ private boolean cacheEnabled;
+
+ /**
+ * Return whether the cache is enabled or not.
+ *
+ * @return {@code true} if cache is enable, otherwise {@code false}
+ */
+ public boolean cacheEnabled() {
+ return cacheEnabled;
+ }
@Override
public void initialize(Config config) throws RuntimeException {
this.backend = createRelationalEntityBackend(config);
this.garbageCollector = new RelationalGarbageCollector(backend, config);
this.garbageCollector.start();
+ this.cacheEnabled = config.get(Configs.CACHE_ENABLED);
+ this.namespaceSet = Sets.newHashSet();
Review Comment:
> What is the usage of `namespaceSet`?
> > Will we store the entities every time `list` is called? I believe in
most cases, this is unnecessary except for the first one.
According to this opinion, it's used to cache the namespaces only during the
first `list()` call. Subsequent calls will skip redundant additions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
