yuqi1129 commented on code in PR #7446:
URL: https://github.com/apache/gravitino/pull/7446#discussion_r2174953020
##########
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/jdbc-mysql/00006_datatype.sql:
##########
@@ -48,29 +49,30 @@ CREATE TABLE tb02 (
f13 DATE NOT NULL ,
f14 TIME NOT NULL ,
f15 TIMESTAMP NOT NULL,
- f16 TIMESTAMP WITH TIME ZONE NOT NULL
+ f16 TIMESTAMP WITH TIME ZONE NOT NULL,
+ f17 JSON NOT NULL
);
show create table tb02;
-INSERT INTO tb02 (f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14,
f15, f16)
+INSERT INTO tb02 (f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f14,
f15, f16, f17)
VALUES ('Sample text 1', 'Text1', x'65', 123.456, 7.89, 12.34, FALSE, 1, 100,
1000, 1000, 100000, DATE '2024-01-01',
- TIME '08:00:00', TIMESTAMP '2024-01-01 08:00:00', TIMESTAMP
'2024-01-01 08:00:00 UTC');
+ TIME '08:00:00', TIMESTAMP '2024-01-01 08:00:00', TIMESTAMP
'2024-01-01 08:00:00 UTC', JSON '{}');
Review Comment:
Can you add some real fields to the JSON string, please?
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/util/json/JsonCodec.java:
##########
@@ -60,6 +62,17 @@ private static ObjectMapper buildMapper(ClassLoader
classLoader) {
}
}
+ private static Type buildJsonType(ClassLoader classLoader) {
+ try {
+ ClassLoader appClassLoader =
Review Comment:
Since the parameter is already an instance of `AppClassloader`, why do we
still need to get a `AppClassLoader` in L68?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
