hqbhoho commented on code in PR #7446:
URL: https://github.com/apache/gravitino/pull/7446#discussion_r2176247676
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/util/json/JsonCodec.java:
##########
@@ -60,6 +62,17 @@ private static ObjectMapper buildMapper(ClassLoader
classLoader) {
}
}
+ private static Type buildJsonType(ClassLoader classLoader) {
+ try {
+ ClassLoader appClassLoader =
Review Comment:
> Since the parameter is already an instance of `AppClassloader`, why do we
still need to get a `AppClassLoader` in L68?
@yuqi1129 The parameter would not be an instance of `AppClassloader`. Trino
plugin will load by `PluginClassLoader` which can't load some class in
`trino-main`.`GravitinoConnectorPluginManager` will be load by `AppClassloader`
only once, so we still need to get a `AppClassLoader` in L68.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
