jerryshao commented on code in PR #6485:
URL: https://github.com/apache/gravitino/pull/6485#discussion_r2178916453
##########
core/src/main/java/org/apache/gravitino/listener/EventBus.java:
##########
@@ -67,12 +69,15 @@ public EventBus(List<EventListenerPlugin> eventListeners) {
* implementation, which could be either synchronous or asynchronous.
*
* @param baseEvent The event to be dispatched to all registered listeners.
+ * @return an Optional containing the transformed pre-event if it implements
{@link
+ * SupportsChangingPreEvent}, otherwise {@link Optional#empty() empty}
*/
- public void dispatchEvent(BaseEvent baseEvent) {
+ public Optional<BaseEvent> dispatchEvent(BaseEvent baseEvent) {
Review Comment:
Where did you use the return value of this method? I am unable to locate the
related modification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
