FANNG1 commented on code in PR #6485:
URL: https://github.com/apache/gravitino/pull/6485#discussion_r2179008465
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/dispatcher/IcebergTableEventDispatcher.java:
##########
@@ -79,20 +81,28 @@ public LoadTableResponse createTable(
NameIdentifier nameIdentifier =
IcebergRestUtils.getGravitinoNameIdentifier(
metalakeName, context.catalogName(), tableIdentifier);
- eventBus.dispatchEvent(
- new IcebergCreateTablePreEvent(context, nameIdentifier,
createTableRequest));
+ Optional<BaseEvent> transformedEvent =
Review Comment:
The event framework provides the guarantee, and I add the null check for the
transformed pre event, it'll be a BUG if the transformed event is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
