yuqi1129 commented on code in PR #7738:
URL: https://github.com/apache/gravitino/pull/7738#discussion_r2227840043
##########
catalogs/catalog-jdbc-starrocks/src/main/java/org/apache/gravitino/catalog/starrocks/operations/StarRocksTableOperations.java:
##########
@@ -51,59 +81,514 @@ protected String generateCreateTableSql(
Transform[] partitioning,
Distribution distribution,
Index[] indexes) {
- throw new NotImplementedException("To be implemented in the future");
+
+ StringBuilder sqlBuilder = new StringBuilder();
+ sqlBuilder.append(String.format("CREATE TABLE `%s` ( \n", tableName));
+ // Add columns
+ sqlBuilder.append(
+ Arrays.stream(columns)
+ .map(
+ column -> {
+ StringBuilder columnsSql = new StringBuilder();
+ columnsSql
+ .append(SPACE)
+ .append(BACK_QUOTE)
+ .append(column.name())
+ .append(BACK_QUOTE);
+ appendColumnDefinition(column, columnsSql);
+ return columnsSql.toString();
+ })
+ .collect(Collectors.joining(",\n")));
+ sqlBuilder.append(")\n");
+ if (StringUtils.isNotEmpty(comment)) {
+ comment = StringIdentifier.addToComment(StringIdentifier.DUMMY_ID,
comment);
+ sqlBuilder.append(" COMMENT \"").append(comment).append("\"");
+ }
+
+ appendPartitionSql(partitioning, columns, sqlBuilder);
+ addDistributionSql(distribution, sqlBuilder);
+ addPropertiesSql(properties, sqlBuilder);
+
+ // Return the generated SQL statement
+ String result = sqlBuilder.toString();
+
+ LOG.info("Generated create table:{} sql: {}", tableName, result);
+ return result;
+ }
+
+ @Override
+ protected String generateAlterTableSql(
+ String databaseName, String tableName, TableChange... changes) {
+ JdbcTable lazyLoadTable = null;
+ List<String> alterSql = new ArrayList<>();
+ List<TableChange.SetProperty> setProperties = new ArrayList<>();
+ for (int i = 0; i < changes.length; i++) {
+ TableChange change = changes[i];
+ if (change instanceof TableChange.AddColumn) {
Review Comment:
Is `SetProperty` not supported for StarRocks?
##########
catalogs/catalog-jdbc-starrocks/src/main/java/org/apache/gravitino/catalog/starrocks/converter/StarRocksTypeConverter.java:
##########
@@ -18,19 +18,137 @@
*/
package org.apache.gravitino.catalog.starrocks.converter;
-import org.apache.commons.lang3.NotImplementedException;
import org.apache.gravitino.catalog.jdbc.converter.JdbcTypeConverter;
import org.apache.gravitino.rel.types.Type;
+import org.apache.gravitino.rel.types.Types;
/** Type converter for StarRocks. */
public class StarRocksTypeConverter extends JdbcTypeConverter {
+
+ static final String BIGINT = "bigint";
+ static final String BOOLEAN = "boolean";
+ static final String DECIMAL = "decimal";
+ static final String DOUBLE = "double";
+ static final String FLOAT = "float";
+ static final String INT = "int";
+ static final String LARGEINT = "largeint";
+ static final String SMALLINT = "smallint";
+ static final String TINYINT = "tinyint";
+
+ static final String BINARY = "binary";
+ static final String VARBINARY = "varbinary";
+ static final String CHAR = "char";
+ static final String STRING = "string";
+ static final String VARCHAR = "varchar";
+
+ static final String DATE = "date";
+ static final String DATETIME = "datetime";
+
+ static final String ARRAY = "array";
+ static final String JSON = "json";
+ static final String MAP = "map";
+ static final String STRUCT = "struct";
+
+ static final String BITMAP = "bitmap";
+ static final String HLL = "hll";
+
+ static final String BIT = "BIT";
Review Comment:
Are these types not yet supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
