taylor12805 commented on code in PR #7738:
URL: https://github.com/apache/gravitino/pull/7738#discussion_r2228183336
##########
catalogs/catalog-jdbc-starrocks/src/main/java/org/apache/gravitino/catalog/starrocks/converter/StarRocksTypeConverter.java:
##########
@@ -18,19 +18,137 @@
*/
package org.apache.gravitino.catalog.starrocks.converter;
-import org.apache.commons.lang3.NotImplementedException;
import org.apache.gravitino.catalog.jdbc.converter.JdbcTypeConverter;
import org.apache.gravitino.rel.types.Type;
+import org.apache.gravitino.rel.types.Types;
/** Type converter for StarRocks. */
public class StarRocksTypeConverter extends JdbcTypeConverter {
+
+ static final String BIGINT = "bigint";
+ static final String BOOLEAN = "boolean";
+ static final String DECIMAL = "decimal";
+ static final String DOUBLE = "double";
+ static final String FLOAT = "float";
+ static final String INT = "int";
+ static final String LARGEINT = "largeint";
+ static final String SMALLINT = "smallint";
+ static final String TINYINT = "tinyint";
+
+ static final String BINARY = "binary";
+ static final String VARBINARY = "varbinary";
+ static final String CHAR = "char";
+ static final String STRING = "string";
+ static final String VARCHAR = "varchar";
+
+ static final String DATE = "date";
+ static final String DATETIME = "datetime";
+
+ static final String ARRAY = "array";
+ static final String JSON = "json";
+ static final String MAP = "map";
+ static final String STRUCT = "struct";
+
+ static final String BITMAP = "bitmap";
+ static final String HLL = "hll";
+
+ static final String BIT = "BIT";
+
@Override
public Type toGravitino(JdbcTypeBean typeBean) {
- throw new NotImplementedException("To be implemented in the future");
+ switch (typeBean.getTypeName().toLowerCase()) {
+ case BIGINT:
+ return Types.LongType.get();
+ case BOOLEAN:
+ return Types.BooleanType.get();
+ case DECIMAL:
+ return Types.DecimalType.of(typeBean.getColumnSize(),
typeBean.getScale());
+ case DOUBLE:
+ return Types.DoubleType.get();
+ case FLOAT:
+ return Types.FloatType.get();
+ case INT:
+ return Types.IntegerType.get();
+ case SMALLINT:
+ return Types.ShortType.get();
+ case TINYINT:
+ return Types.ByteType.get();
+ case BINARY:
+ case VARBINARY:
+ return Types.BinaryType.get();
+ case CHAR:
+ return Types.FixedCharType.of(typeBean.getColumnSize());
+ case STRING:
+ return Types.StringType.get();
+ case VARCHAR:
+ if (typeBean.getColumnSize() == 65533) {
Review Comment:
Not quite understand this. If want to convert varchar which column size less
than 65533 as String, is typeBean.getColumnSize() <= 65533 more suitable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
