bharos commented on PR #8232: URL: https://github.com/apache/gravitino/pull/8232#issuecomment-3211205448
> hi, all the UI test is under web/integration-test, can you change it to match this? Thanks! Hi! I think what I'm adding: JavaScript unit tests for frontend code (OAuth/OIDC logic) is isolated unit tests using Vitest co-located with source code What exists in `web/integration-test` is Java Selenium E2E tests which is full browser automation testing complete user workflows I feel these are complementary - unit tests for fast developer feedback, E2E tests for integration validation. Both are standard in modern web projects and serve different purposes ? Are you suggesting to convert the tests I added to Selenium ? I mostly wanted to test only some login logic and not end to end flow (which I guess is harder to test as well) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
