xunliu commented on PR #8232: URL: https://github.com/apache/gravitino/pull/8232#issuecomment-3212881065
hi @bharos Thank you for your contributions. > I feel these are complementary - unit tests for fast developer feedback, E2E tests for integration validation. > Both are standard in modern web projects and serve different purposes ? > > Are you suggesting to convert the tests I added to Selenium ? I mostly wanted to test only some login logic and not end to end flow (which I guess is harder to test as well) I agree with you. > > Both are standard in modern web projects and serve different purposes > > I agree with you. > > It would be best to add login testing to the end to end process. Whether or not to introduce unit tests for the front end, WDYT？ @xunliu hi @LauraXia123 I think if we use E2E to test OAuth login logic, it will be very hard, So, I think we can use this UT. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
