mchades commented on code in PR #7789:
URL: https://github.com/apache/gravitino/pull/7789#discussion_r2296993863


##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/converter/HiveTableConverter.java:
##########
@@ -98,6 +102,8 @@ Column[] getColumns(Table table, BUILDER columnBuilder) {
                             .withComment(f.getComment())
                             .build()),
             table.getPartitionKeys().stream()
+                // Filter out partition keys that already exist in sd.getCols()
+                .filter(p -> !columnNames.contains(p.getName()))

Review Comment:
   I'm thinking about this: if we filter out duplicated partition keys, the 
partitioning information becomes incomplete. So, should we filter the 
duplicated field in cols?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to