TEOTEO520 commented on code in PR #7789:
URL: https://github.com/apache/gravitino/pull/7789#discussion_r2300350603
##########
catalogs/hive-metastore-common/src/main/java/org/apache/gravitino/hive/converter/HiveTableConverter.java:
##########
@@ -98,6 +102,8 @@ Column[] getColumns(Table table, BUILDER columnBuilder) {
.withComment(f.getComment())
.build()),
table.getPartitionKeys().stream()
+ // Filter out partition keys that already exist in sd.getCols()
+ .filter(p -> !columnNames.contains(p.getName()))
Review Comment:
The current implementation (prioritizing regular columns) is reasonable
because:
1. Regular columns contain the actual data
2. Partitioning information can be obtained separately via getPartitioning()
without loss
3. It aligns with Hive's design principles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
