jerryshao commented on code in PR #8922:
URL: https://github.com/apache/gravitino/pull/8922#discussion_r2471837788
##########
catalogs/catalog-generic-lakehouse/src/main/java/org/apache/gravitino/catalog/lakehouse/lance/LanceCatalogOperations.java:
##########
@@ -117,15 +119,16 @@ public Table createTable(
Index[] indexes)
throws NoSuchSchemaException, TableAlreadyExistsException {
// Ignore partitions, distributions, sortOrders, and indexes for Lance
tables;
- String location = properties.get(LOCATION);
+ String location =
properties.get(GenericLakehouseTablePropertiesMetadata.LAKEHOUSE_LOCATION);
Map<String, String> storageProps =
properties.entrySet().stream()
.filter(e ->
e.getKey().startsWith(LANCE_TABLE_STORAGE_OPTION_PREFIX))
.collect(
Collectors.toMap(
e ->
e.getKey().substring(LANCE_TABLE_STORAGE_OPTION_PREFIX.length()),
Map.Entry::getValue));
- try (Dataset dataset =
+
+ try (Dataset ignored =
Review Comment:
Why do we name it as `ignored`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
