mchades commented on code in PR #8922:
URL: https://github.com/apache/gravitino/pull/8922#discussion_r2471843205


##########
api/src/main/java/org/apache/gravitino/rel/Table.java:
##########
@@ -99,6 +99,33 @@ default Map<String, String> properties() {
     return Collections.emptyMap();
   }
 
+  /**
+   * Formats the table as a string representation.
+   *
+   * @return the formatted string representation of the table
+   */
+  default String format() {
+    throw new UnsupportedOperationException("Table format is not supported.");
+  }
+
+  /**
+   * Gets the location of the table.
+   *
+   * @return the location of the table
+   */
+  default String location() {

Review Comment:
   Does the table property also contain this?



##########
api/src/main/java/org/apache/gravitino/rel/Table.java:
##########
@@ -99,6 +99,33 @@ default Map<String, String> properties() {
     return Collections.emptyMap();
   }
 
+  /**
+   * Formats the table as a string representation.
+   *
+   * @return the formatted string representation of the table
+   */
+  default String format() {
+    throw new UnsupportedOperationException("Table format is not supported.");
+  }
+
+  /**
+   * Gets the location of the table.
+   *
+   * @return the location of the table
+   */
+  default String location() {
+    throw new UnsupportedOperationException("Table location is not 
supported.");
+  }
+
+  /**
+   * Indicates whether the table is external.
+   *
+   * @return true if the table is external, false otherwise
+   */

Review Comment:
   Can you explain in detail the meaning of `external`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to