jerryshao commented on code in PR #8975:
URL: https://github.com/apache/gravitino/pull/8975#discussion_r2480011102
##########
common/src/main/java/org/apache/gravitino/json/JsonUtils.java:
##########
@@ -479,6 +502,85 @@ private static void writeFunctionArg(FunctionArg arg,
JsonGenerator gen) throws
gen.writeEndObject();
}
+ private static void writeExpression(Expression expression, JsonGenerator
gen) throws IOException {
Review Comment:
I guess the implementation is quite similar to `xxxDTO` serde, maybe we can
reuse the code. Otherwise, we have to change twice.
Another solution is that when we store these into the database, we can
convert the `xxxImpl` to `xxxDTO`, and then using the existing serde method to
do the serialization and deserialization. With this, we don't have to implement
the serde method for these `xxxImpl`.
What do you think @yuqi1129 @mchades ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
