yuqi1129 commented on code in PR #8975:
URL: https://github.com/apache/gravitino/pull/8975#discussion_r2480016218


##########
common/src/main/java/org/apache/gravitino/json/JsonUtils.java:
##########
@@ -479,6 +502,85 @@ private static void writeFunctionArg(FunctionArg arg, 
JsonGenerator gen) throws
     gen.writeEndObject();
   }
 
+  private static void writeExpression(Expression expression, JsonGenerator 
gen) throws IOException {

Review Comment:
   In the first edition, I have just converted Impl to DTO and reused the DTO 
serializer and deserializer to handle it. However, since DTO and Impl play 
different roles, I chose to create new serializers finally. Theoretically, both 
are okay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to